20240903.1 #21865
Closed
20240903.1 #21865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.6...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add padding to no info badge * Update src/panels/lovelace/badges/hui-entity-badge.ts Co-authored-by: Paul Bottein <[email protected]> --------- Co-authored-by: Paul Bottein <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-actions
bot
added
GitHub Actions
WalkthroughWalkthroughThe changes involve updates to dependency versions in configuration files, enhancements to markdown rendering capabilities, and modifications to user interface components. Specifically, the Changes
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
src/components/ha-markdown-element.ts (1)
99-117: LGTM! The code changes are logically correct and well-structured.The introduced conditional check correctly handles the case when
breaksproperty is false and modifies the text content of the first child node to exclude the first line. This ensures that the first line of the blockquote is not considered in the output.Suggestion: Simplify the conditions for checking the first child node.
To improve readability, you can combine the conditions for checking the first child node into a single
ifstatement.Apply this diff to simplify the code segment:
-if (!this.breaks && arr.length) { - // When we are not breaking, the first line of the blockquote is not considered, - // so we need to adjust the first child text content - const firstChild = arr[0]; - if ( - firstChild.nodeType === Node.TEXT_NODE && - firstChild.textContent === gitHubAlertMatch.input && - firstChild.textContent?.includes("\n") - ) { +if ( + !this.breaks && + arr.length && + arr[0].nodeType === Node.TEXT_NODE && + arr[0].textContent === gitHubAlertMatch.input && + arr[0].textContent?.includes("\n") +) { + const firstChild = arr[0]; firstChild.textContent = firstChild.textContent .split("\n") .slice(1) .join("\n"); - } -}
github-actions
bot
removed
GitHub Actions
ludeeus
temporarily deployed
to
Cast Development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
row_spanfor enhanced layout configuration in sections.Bug Fixes
Improvements
Chores