-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240903.1 #21865
20240903.1 #21865
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.6 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.3.6...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add padding to no info badge * Update src/panels/lovelace/badges/hui-entity-badge.ts Co-authored-by: Paul Bottein <[email protected]> --------- Co-authored-by: Paul Bottein <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
WalkthroughWalkthroughThe changes involve updates to dependency versions in configuration files, enhancements to markdown rendering capabilities, and modifications to user interface components. Specifically, the Changes
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
src/components/ha-markdown-element.ts (1)
99-117
: LGTM! The code changes are logically correct and well-structured.The introduced conditional check correctly handles the case when
breaks
property is false and modifies the text content of the first child node to exclude the first line. This ensures that the first line of the blockquote is not considered in the output.Suggestion: Simplify the conditions for checking the first child node.
To improve readability, you can combine the conditions for checking the first child node into a single
if
statement.Apply this diff to simplify the code segment:
-if (!this.breaks && arr.length) { - // When we are not breaking, the first line of the blockquote is not considered, - // so we need to adjust the first child text content - const firstChild = arr[0]; - if ( - firstChild.nodeType === Node.TEXT_NODE && - firstChild.textContent === gitHubAlertMatch.input && - firstChild.textContent?.includes("\n") - ) { +if ( + !this.breaks && + arr.length && + arr[0].nodeType === Node.TEXT_NODE && + arr[0].textContent === gitHubAlertMatch.input && + arr[0].textContent?.includes("\n") +) { + const firstChild = arr[0]; firstChild.textContent = firstChild.textContent .split("\n") .slice(1) .join("\n"); - } -}
Summary by CodeRabbit
New Features
row_span
for enhanced layout configuration in sections.Bug Fixes
Improvements
Chores